Skip to content

Conversation

asr41
Copy link

@asr41 asr41 commented Sep 2, 2025

Merge BRGR-autopilot which contains scripts with master

[![Autotest Status](https://autotest.ardupilot.org/autotest-badge.svg)](https://autotest.ardupilot.org/)

ArduPilot is the most advanced, full-featured, and reliable open source autopilot software available.
ArduPilot is the most advanced, full-featured, and reliable open source autopilot software availabll
Copy link
Contributor

@cclauss cclauss Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Also, please fix the lua linting issues and the ⛔ symbol at the end of several .lua files.

Checking ROMFS_custom/scripts/grid_fin_mixing.lua 2 warnings
Error: ROMFS_custom/scripts/grid_fin_mixing.lua:44:19: value assigned to variable V_air is unused
Error: ROMFS_custom/scripts/grid_fin_mixing.lua:114:11: unused variable effective_aoa

Checking ROMFS_custom/scripts/lockouts.lua 1 warning
Error: ROMFS_custom/scripts/lockouts.lua:123:9: empty if branch

@@ -1,3 +1,4 @@
/ArduPlane/ap-*.core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should explain this proposed change.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is quite an interesting PR!

Did you really mean to create a merge to master ArduPilot for your code? This looks more like an "OEM" setup which you've accidentally PRd?

Some things in here would be good to get into master, but most of this wouldn't be suitable as it currently stands.

@peterbarker
Copy link
Contributor

No answer, assuming someone goofed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants